fix(entity): add argument ignore_not_found to ignore "not found" errors
#2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2628 +/- ##
==========================================
+ Coverage 32.83% 33.78% +0.95%
==========================================
Files 98 98
Lines 26872 26884 +12
==========================================
+ Hits 8824 9084 +260
+ Misses 17890 17600 -290
- Partials 158 200 +42 ☔ View full report in Codecov by Sentry. |
pranav-new-relic
changed the title
ignore_not_found to ignore "not found" errors
mbazhlekova
approved these changes
Mar 27, 2024
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Relic Internal
Jira
Summary
This PR proposes the addition of a new attribute
ignore_not_foundto thenewrelic_entitydata source in order to "ignore" not found errors if settruein the configuration, thereby stopping automated Terraform pipelines from halting if the entity is lost, which is useful in cases when the entity abruptly expires (see original usecase proposed by the customer in #2599).Testing
The changes have been manually verified multifold. The test cases could not be updated because they fail with an
"id" not found error, since the data source fetches no entity, which we try validating (without the expectation of an error being thrown, instead).